Fix to_timestamps to support Z for %z format specifier #10617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10617 +/- ##
================================================
+ Coverage 86.30% 86.34% +0.03%
================================================
Files 140 140
Lines 22255 22280 +25
================================================
+ Hits 19207 19237 +30
+ Misses 3048 3043 -5
Continue to review full report at Codecov.
|
vyasr
approved these changes
Apr 8, 2022
hyperbolic2346
approved these changes
Apr 8, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10609
This adds support for 'Z' in a timestamp string for the
%zspecifier. Normally, the%zspecifier expects an hour-minute format like+HHMMbut strptime and other libraries also accept a single 'Z' here. The following two strings should result in the same timestamp value:"2022-04-07 09:15:00Z" and "2022-04-07 09:15:00+0000"The
cudf::strings::is_timestampandcudf::strings::to_timestampshave been updated to support this behavior. A gtest was updated to include this as a testcase.