-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix strings strip() to accept only str Scalar for to_strip parameter #10597
Fix strings strip() to accept only str Scalar for to_strip parameter #10597
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add test(s) for passing the incorrect input type for some of these methods?
Yes. I think that is a good idea. |
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10597 +/- ##
================================================
+ Coverage 86.29% 86.31% +0.02%
================================================
Files 140 140
Lines 22255 22255
================================================
+ Hits 19205 19210 +5
+ Misses 3050 3045 -5
Continue to review full report at Codecov.
|
@gpucibot merge |
Closes #10591
Ensures
to_strip
parameter is astr
type when converting it tocudf.Scalar
. It will now through aTypeError
as followsThis will also prevent the sticky CUDA error.
Also, added the
str
parameter to othercudf.Scalar
calls where only strings are supported as well.