Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Update copyrights with respect to main #10595

Merged
merged 1 commit into from
Apr 5, 2022
Merged

[REVIEW] Update copyrights with respect to main #10595

merged 1 commit into from
Apr 5, 2022

Conversation

galipremsagar
Copy link
Contributor

@bdice spotted some copyright failures in #10512

This is because CI copyright checks were introduced in between of 22.04 release and some files that were modified prior to that didn't have their copyrights updated, so this PR updates those missing files.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 5, 2022
@galipremsagar galipremsagar requested a review from a team as a code owner April 5, 2022 14:52
@galipremsagar galipremsagar requested review from a team as code owners April 5, 2022 14:52
@galipremsagar galipremsagar self-assigned this Apr 5, 2022
@galipremsagar galipremsagar requested review from shwina, rgsl888prabhu and vuule and removed request for a team April 5, 2022 14:52
@github-actions github-actions bot added CMake CMake build issue Java Affects Java cuDF API. Python Affects Python cuDF API. gpuCI libcudf Affects libcudf (C++/CUDA) code. labels Apr 5, 2022
@vuule
Copy link
Contributor

vuule commented Apr 5, 2022

Should this be targeting 22.06? 22.04 is at the end of code freeze.

@galipremsagar
Copy link
Contributor Author

Should this be targeting 22.06? 22.04 is at the end of code freeze.

We need this in 22.04 because the release PR is blocked on CI style checks.

@bdice
Copy link
Contributor

bdice commented Apr 5, 2022 •
edited
Loading

@vuule The copyright check is failing on the release PR #10512. I’m not sure if we must fix this before release, or if we just want to do an admin override of the failing check. I don’t think the problem will reoccur on the 22.06 release.

@ajschmidt8 ajschmidt8 merged commit 7a415f3 into rapidsai:branch-22.04 Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@shwina shwina Awaiting requested review from shwina shwina is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@rgsl888prabhu rgsl888prabhu Awaiting requested review from rgsl888prabhu rgsl888prabhu is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@vuule vuule Awaiting requested review from vuule vuule is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@galipremsagar galipremsagar

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@galipremsagar @vuule @bdice @ajschmidt8