Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cudf::strings::count_re API to use count_matches utility #10580

Merged
merged 12 commits into from
Apr 11, 2022

Conversation

davidwendt
Copy link
Contributor

Refactors the cudf::strings::detail::count_re function to reuse the cudf::strings::detail::count_matches utility created for findall, extractall, and split. The kernel code was identical with the only main difference the size of the output column. So the output size was added as a parameter to count_matches and the callers appropriately updated.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 4, 2022
@davidwendt davidwendt self-assigned this Apr 4, 2022
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #10580 (185ccdc) into branch-22.06 (26c1810) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 185ccdc differs from pull request most recent head 01aa70f. Consider uploading reports for the commit 01aa70f to get more accurate results

@@               Coverage Diff                @@
##           branch-22.06   #10580      +/-   ##
================================================
+ Coverage         86.31%   86.33%   +0.01%     
================================================
  Files               140      140              
  Lines             22280    22280              
================================================
+ Hits              19232    19236       +4     
+ Misses             3048     3044       -4     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/string.py 89.10% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.72% <0.00%> (+0.22%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 90.62% <0.00%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cc3d8b...01aa70f. Read the comment docs.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Apr 5, 2022
@davidwendt davidwendt marked this pull request as ready for review April 5, 2022 17:29
@davidwendt davidwendt requested a review from a team as a code owner April 5, 2022 17:29
@davidwendt davidwendt requested review from bdice and codereport April 5, 2022 17:29
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Looks good to me. 👍

Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of suggestions, but nothing blocking. Feel free to address or not depending on what you think.

cpp/src/strings/count_matches.cu Outdated Show resolved Hide resolved
cpp/src/strings/count_matches.cu Show resolved Hide resolved
@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit df6bd3c into rapidsai:branch-22.06 Apr 11, 2022
@davidwendt davidwendt deleted the strings-count-re-factor branch April 11, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants