Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin CMake to prevent 3.23 bugs #10544

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Pin CMake to prevent 3.23 bugs #10544

merged 1 commit into from
Mar 31, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Mar 30, 2022

CMake 3.23 appears to have a bug relating to CUDA support that breaks our builds.

@vyasr vyasr added bug Something isn't working 3 - Ready for Review Ready for review by team CMake CMake build issue ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround non-breaking Non-breaking change labels Mar 30, 2022
@vyasr vyasr requested a review from a team as a code owner March 30, 2022 17:37
@vyasr vyasr self-assigned this Mar 30, 2022
@vyasr vyasr requested a review from robertmaynard March 30, 2022 17:37
@github-actions github-actions bot added conda and removed CMake CMake build issue labels Mar 30, 2022
@galipremsagar galipremsagar added ! - Release and removed ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround labels Mar 30, 2022
@vyasr
Copy link
Contributor Author

vyasr commented Mar 30, 2022

Not sure why there's a CMake style failure here since no CMake was changed. Investigating.

@vyasr
Copy link
Contributor Author

vyasr commented Mar 30, 2022

rerun tests

@codecov
Copy link

codecov bot commented Mar 30, 2022 •
edited
Loading

Codecov Report

Merging #10544 (1cccc29) into branch-22.04 (ee3bb0b) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           branch-22.04   #10544   +/-   ##
=============================================
  Coverage         86.17%   86.17%           
=============================================
  Files               141      141           
  Lines             22510    22510           
=============================================
  Hits              19398    19398           
  Misses             3112     3112

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c42cee3...1cccc29. Read the comment docs.

@jjacobelli jjacobelli merged commit a02b7c2 into rapidsai:branch-22.04 Mar 31, 2022
@vyasr vyasr deleted the pin_cmake branch March 31, 2022 20:09
@robertmaynard
Copy link
Contributor

Do we also need to pin https://github.com/rapidsai/cudf/blob/branch-22.04/conda/recipes/cudf_kafka/meta.yaml# ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@robertmaynard robertmaynard Awaiting requested review from robertmaynard

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vyasr @robertmaynard @ajschmidt8 @jjacobelli @galipremsagar