Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin click version to last support by black<22.3.0. #10535

Merged
merged 4 commits into from
Mar 30, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Mar 29, 2022

This PR pins Click to a version supported by the version of black that we use. #10523 is too disruptive to backport to 22.04 in the middle of a release, so this is a minimum change to unblock linter runs.

@vyasr vyasr added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround non-breaking Non-breaking change labels Mar 29, 2022
@vyasr vyasr self-assigned this Mar 29, 2022
@vyasr vyasr requested a review from a team as a code owner March 29, 2022 22:04
@vyasr vyasr added the bug Something isn't working label Mar 29, 2022
@github-actions github-actions bot added conda and removed Python Affects Python cuDF API. labels Mar 29, 2022
@vyasr
Copy link
Contributor Author

vyasr commented Mar 30, 2022

@galipremsagar any idea what's up with the dask failures? Did something change in dask recently?

@vyasr
Copy link
Contributor Author

vyasr commented Mar 30, 2022

It looks like dask/dask#8806 changed the setter for dask.DataFrame.divisions to only accept tuples, not generic iterables. We need to update our call here, but I don't think we should have to do that for 22.04 at this point. @galipremsagar what do we usually do in situations like this? The tests are being run in a container with INSTALL_DASK_MAIN=1 so that they install the nightly even though we have pinnings. Should we just admin merge this since any future runs of these tests during the release will be run with the dask pinnings?

CC @shwina @ajschmidt8 @quasiben

@galipremsagar
Copy link
Contributor

galipremsagar commented Mar 30, 2022

Yeah, I missed flipping the INSTALL_DASK_MAIN env variable to 0 in #10481, made changes in your PR.

@github-actions github-actions bot added the gpuCI label Mar 30, 2022
@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #10535 (ee3bb0b) into branch-22.04 (54918d8) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head ee3bb0b differs from pull request most recent head d30b4f6. Consider uploading reports for the commit d30b4f6 to get more accurate results

@@               Coverage Diff                @@
##           branch-22.04   #10535      +/-   ##
================================================
+ Coverage         86.15%   86.17%   +0.02%     
================================================
  Files               141      141              
  Lines             22510    22510              
================================================
+ Hits              19393    19398       +5     
+ Misses             3117     3112       -5     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/string.py 88.91% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.72% <0.00%> (+0.22%) ⬆️
python/cudf/cudf/core/column/numerical.py 95.62% <0.00%> (+0.29%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 90.69% <0.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c200bf...d30b4f6. Read the comment docs.

@jjacobelli jjacobelli merged commit c42cee3 into rapidsai:branch-22.04 Mar 30, 2022
rapids-bot bot pushed a commit that referenced this pull request Mar 30, 2022
…0541)

This PR undoes #10535 (which was just a patch for cudf 22.04) on cudf 22.06 since we have implemented the longer term solution in #10523.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Ashwin Srinath (https://github.com/shwina)

URL: #10541
@vyasr vyasr deleted the pin_click branch March 31, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants