-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin click version to last support by black<22.3.0. #10535
Conversation
@galipremsagar any idea what's up with the dask failures? Did something change in dask recently? |
It looks like dask/dask#8806 changed the setter for |
Yeah, I missed flipping the |
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10535 +/- ##
================================================
+ Coverage 86.15% 86.17% +0.02%
================================================
Files 141 141
Lines 22510 22510
================================================
+ Hits 19393 19398 +5
+ Misses 3117 3112 -5
Continue to review full report at Codecov.
|
…0541) This PR undoes #10535 (which was just a patch for cudf 22.04) on cudf 22.06 since we have implemented the longer term solution in #10523. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Ashwin Srinath (https://github.com/shwina) URL: #10541
This PR pins Click to a version supported by the version of black that we use. #10523 is too disruptive to backport to 22.04 in the middle of a release, so this is a minimum change to unblock linter runs.