Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix temp data cleanup in test_text.py #10524

Merged

Conversation

brandon-b-miller
Copy link
Contributor

Noticed that when running pytests, cuDF was leaving a temporary file used for a specific test in the testing data folder without removing it. I think our tests mostly write to tmp to avoid this issue.

In switching it to point to tmp I noticed the intended data is not being actually written to the file, instead it was writing the string __repr__ of the generator. I also shrunk the data size by many orders of magnitude, because in the intended case where the data is meant to be truly generated, 30 mil ends up being a little cumbersome and slow.

@brandon-b-miller brandon-b-miller added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. non-breaking Non-breaking change labels Mar 28, 2022
@brandon-b-miller brandon-b-miller requested a review from a team as a code owner March 28, 2022 18:52
@galipremsagar
Copy link
Contributor

galipremsagar commented Mar 28, 2022

cc: @cwharris
FYI about size reduction in pytest.

@cwharris
Copy link
Contributor

thanks!

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Mar 28, 2022
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.06@90882d3). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.06   #10524   +/-   ##
===============================================
  Coverage                ?   86.34%           
===============================================
  Files                   ?      140           
  Lines                   ?    22294           
  Branches                ?        0           
===============================================
  Hits                    ?    19249           
  Misses                  ?     3045           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90882d3...5d01d2e. Read the comment docs.

@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 62360cb into rapidsai:branch-22.06 Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants