Fix temp data cleanup in test_text.py
#10524
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that when running pytests, cuDF was leaving a temporary file used for a specific test in the testing data folder without removing it. I think our tests mostly write to
tmp
to avoid this issue.In switching it to point to
tmp
I noticed the intended data is not being actually written to the file, instead it was writing the string__repr__
of the generator. I also shrunk the data size by many orders of magnitude, because in the intended case where the data is meant to be truly generated, 30 mil ends up being a little cumbersome and slow.