Add column field ID control in parquet writer #10504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointKernel
added
feature request
PointKernel
changed the title
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10504 +/- ##
================================================
+ Coverage 86.33% 86.37% +0.03%
================================================
Files 140 142 +2
Lines 22289 22356 +67
================================================
+ Hits 19244 19310 +66
- Misses 3045 3046 +1
Continue to review full report at Codecov.
|
jlowe
reviewed
Mar 30, 2022
jlowe
previously approved these changes
Mar 31, 2022
jlowe
dismissed
their stale review
Looks like the Java build is failing on a chunked write with "Optional has no value". Is there a place that was missed for handling chunked writes?
jlowe
approved these changes
Mar 31, 2022
PointKernel
added
3 - Ready for Review
|
@res-life Thanks! I just gave you the write access to my repo. Can you please add the JNI bindings and tests to this PR? |
Signed-off-by: Chong Gao <[email protected]>
Signed-off-by: Chong Gao <[email protected]>
Signed-off-by: Chong Gao <[email protected]>
|
@jlowe help review JNI part |
…f into parquet-field-id-writing
devavret
approved these changes
Apr 13, 2022
jlowe
reviewed
Apr 13, 2022
| * Set a simple child meta data | ||
| * @return this for chaining. | ||
| */ | ||
| public T withColumns(boolean nullable, String name, int parquetFieldId) { |
There was a problem hiding this comment.
This should be withColumn since it's only adding a single column.
added 2 commits
April 14, 2022 10:42
…f into parquet-field-id-writing
jlowe
reviewed
Apr 14, 2022
jlowe
approved these changes
Apr 15, 2022
|
@gpucibot merge |
vyasr
added
4 - Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10375
Closes #10376
This PR enables column
field_idcontrol in the parquet writer. When writing a parquet file, users can specify a column'sfield_idviacolumn_in_metadata.set_parquet_field_id(). JNI bindings and uni tests are added as well.