Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Add scipy skip for a test #10502

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

galipremsagar
Copy link
Contributor

This PR skips scipy related code-path that pandas takes. This isn't a failure in CI, but cudf dev env doesn't require having a scipy package, hence adding an importorskip.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Mar 23, 2022
@galipremsagar galipremsagar requested a review from a team as a code owner March 23, 2022 22:54
@galipremsagar galipremsagar self-assigned this Mar 23, 2022
@galipremsagar galipremsagar added the improvement Improvement / enhancement to an existing function label Mar 23, 2022
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine squeezing this in during burndown since it's caused by another PR that was merged during burndown.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Mar 23, 2022
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #10502 (6594610) into branch-22.04 (18398ab) will increase coverage by 0.01%.
The diff coverage is 85.71%.

@@               Coverage Diff                @@
##           branch-22.04   #10502      +/-   ##
================================================
+ Coverage         86.16%   86.17%   +0.01%     
================================================
  Files               141      141              
  Lines             22501    22510       +9     
================================================
+ Hits              19387    19398      +11     
+ Misses             3114     3112       -2     
Impacted Files Coverage Δ
python/cudf/cudf/core/dataframe.py 93.50% <77.77%> (-0.09%) ⬇️
python/cudf/cudf/core/series.py 95.19% <100.00%> (+0.01%) ⬆️
python/cudf/cudf/core/column/string.py 88.91% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.72% <0.00%> (+0.22%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 90.69% <0.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12b66a3...6594610. Read the comment docs.

@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 54918d8 into rapidsai:branch-22.04 Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants