Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move benchmark input generation in device in reduction nvbench #10486

Merged
merged 1 commit into from
Mar 28, 2022
Merged

move benchmark input generation in device in reduction nvbench #10486

merged 1 commit into from
Mar 28, 2022

Conversation

karthikeyann
Copy link
Contributor

Addresses part of #5773
uses create_random_table and moves benchmark input generation in device in reduction nvbench

@karthikeyann karthikeyann added feature request New feature or request 3 - Ready for Review Ready for review by team tests Unit testing for project libcudf Affects libcudf (C++/CUDA) code. 4 - Needs Review Waiting for reviewer to review or respond Performance Performance related issue tech debt non-breaking Non-breaking change labels Mar 22, 2022
@karthikeyann karthikeyann requested a review from a team as a code owner March 22, 2022 21:21
@karthikeyann karthikeyann self-assigned this Mar 22, 2022
@karthikeyann karthikeyann requested review from cwharris and vyasr March 22, 2022 21:21
@karthikeyann
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Mar 25, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.06@df8b195). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 7b9f764 differs from pull request most recent head 656e7c3. Consider uploading reports for the commit 656e7c3 to get more accurate results

@@               Coverage Diff               @@
##             branch-22.06   #10486   +/-   ##
===============================================
  Coverage                ?   86.31%           
===============================================
  Files                   ?      140           
  Lines                   ?    22312           
  Branches                ?        0           
===============================================
  Hits                    ?    19259           
  Misses                  ?     3053           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df8b195...656e7c3. Read the comment docs.

@karthikeyann karthikeyann added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond labels Mar 28, 2022
@karthikeyann
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0d78007 into rapidsai:branch-22.06 Mar 28, 2022
@GregoryKimball GregoryKimball mentioned this pull request Jun 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@cwharris cwharris cwharris approved these changes

Assignees

@karthikeyann karthikeyann

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Performance Performance related issue tests Unit testing for project
Projects
None yet
Milestone
C++ Benchmark Runtime Improvements
Development

Successfully merging this pull request may close these issues.
3 participants
@karthikeyann @cwharris @vyasr