Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include <cstddef> to fix compilation of parquet reader on GCC 11. #10483

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Mar 22, 2022

Includes <cstddef> for ptrdiff_t in parquet/compact_protocol_reader.hpp. Compilation fails on GCC 11 without this include. Targeting 22.04 since this was broken yesterday in #10063.

Error output:

cudf/cpp/src/io/parquet/compact_protocol_reader.hpp:51:17: error: 'ptrdiff_t' does not name a type
   51 |   [[nodiscard]] ptrdiff_t bytecount() const noexcept { return m_cur - m_base; }
      |
cudf/cpp/src/io/parquet/compact_protocol_reader.hpp:22:1: note: 'ptrdiff_t' is defined in header '<cstddef>'; did you forget to '#include <cstddef>'?

Also includes <optional> in cpp/include/cudf/table/experimental/row_operators.cuh, which was broken by #10164.

@bdice bdice requested review from a team as code owners March 22, 2022 19:01
@bdice bdice requested review from trxcllnt and codereport March 22, 2022 19:01
@github-actions github-actions bot added CMake CMake build issue conda Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Mar 22, 2022
@bdice bdice requested a review from PointKernel March 22, 2022 19:02
@bdice bdice self-assigned this Mar 22, 2022
@bdice bdice force-pushed the fix/parquet-compact-protocol-reader-include-cstddef branch from f005b8e to d287280 Compare March 22, 2022 19:03
@bdice bdice removed gpuCI CMake CMake build issue Java Affects Java cuDF API. labels Mar 22, 2022
@bdice bdice removed request for a team March 22, 2022 19:04
Copy link
Contributor

@codereport codereport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@bdice bdice added bug Something isn't working non-breaking Non-breaking change labels Mar 22, 2022
@codereport codereport added tech debt bug Something isn't working and removed bug Something isn't working labels Mar 22, 2022
@bdice bdice removed the bug Something isn't working label Mar 22, 2022
@bdice bdice added the improvement Improvement / enhancement to an existing function label Mar 22, 2022
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #10483 (c3e0dc2) into branch-22.04 (4ee78fb) will increase coverage by 0.03%.
The diff coverage is 91.07%.

❗ Current head c3e0dc2 differs from pull request most recent head 34cf1fe. Consider uploading reports for the commit 34cf1fe to get more accurate results

@@               Coverage Diff                @@
##           branch-22.04   #10483      +/-   ##
================================================
+ Coverage         86.14%   86.17%   +0.03%     
================================================
  Files               139      141       +2     
  Lines             22447    22501      +54     
================================================
+ Hits              19336    19391      +55     
+ Misses             3111     3110       -1     
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/io/text.py 85.29% <85.29%> (ø)
python/dask_cudf/dask_cudf/__init__.py 82.35% <100.00%> (ø)
python/dask_cudf/dask_cudf/io/__init__.py 75.00% <100.00%> (+3.57%) ⬆️
python/dask_cudf/dask_cudf/io/tests/test_orc.py 100.00% <100.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_text.py 100.00% <100.00%> (ø)
python/cudf/cudf/core/column/string.py 88.91% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.72% <0.00%> (+0.22%) ⬆️
python/dask_cudf/dask_cudf/core.py 73.62% <0.00%> (+0.26%) ⬆️
python/cudf/cudf/core/column/numerical.py 95.62% <0.00%> (+0.29%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d386d26...34cf1fe. Read the comment docs.

@bdice
Copy link
Contributor Author

bdice commented Mar 22, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0a2aa98 into rapidsai:branch-22.04 Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants