Namespace/Docstring Fixes for Reduction #10471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ented reduction Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
bdice
reviewed
Mar 21, 2022
bdice
added
improvement
isVoid
commented
Mar 21, 2022
|
This is breaking because it changes namespaces by moving internal code into a |
hyperbolic2346
approved these changes
Mar 24, 2022
| @@ -192,6 +192,8 @@ std::unique_ptr<scalar> mean( | |||
| * | |||
| * @param col input column to compute variance. | |||
| * @param output_dtype data type of return type and typecast elements of input column. | |||
| * @param ddof Delta degrees of freedom. The divisor used is N - ddof, where N represents the number | |||
| * of elements. | |||
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10471 +/- ##
===============================================
Coverage ? 86.31%
===============================================
Files ? 140
Lines ? 22312
Branches ? 0
===============================================
Hits ? 19259
Misses ? 3053
Partials ? 0 Continue to review full report at Codecov.
|
bdice
approved these changes
Mar 24, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds detail namespace for for simple/compound ops for reduction to make code more consistent with segmented reduction. It also includes minor docstring fixes.
cc @bdice