Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StringIO support to read_text #10465

Merged
merged 8 commits into from
Mar 23, 2022
Merged

Add StringIO support to read_text #10465

merged 8 commits into from
Mar 23, 2022

Conversation

cwharris
Copy link
Contributor

Add StringIO support to read_text.

@cwharris cwharris requested a review from a team as a code owner March 19, 2022 19:21
@cwharris cwharris requested review from shwina and bdice March 19, 2022 19:21
@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 19, 2022
@cwharris cwharris added feature request New feature or request 2 - In Progress Currently a work in progress non-breaking Non-breaking change and removed Python Affects Python cuDF API. labels Mar 19, 2022
@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 19, 2022
@cwharris
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Mar 21, 2022 •
edited
Loading

Codecov Report

Merging #10465 (f381414) into branch-22.04 (21ed251) will increase coverage by 0.21%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           branch-22.04   #10465      +/-   ##
================================================
+ Coverage         85.95%   86.17%   +0.21%     
================================================
  Files               139      141       +2     
  Lines             22435    22510      +75     
================================================
+ Hits              19285    19398     +113     
+ Misses             3150     3112      -38
Impacted Files Coverage Δ
python/cudf/cudf/core/single_column_frame.py 96.85% <0.00%> (-0.17%) ⬇️
python/cudf/cudf/core/dataframe.py 93.50% <0.00%> (-0.08%) ⬇️
python/cudf/cudf/core/column/datetime.py 88.51% <0.00%> (-0.05%) ⬇️
python/cudf/cudf/core/column/timedelta.py 90.45% <0.00%> (-0.05%) ⬇️
python/cudf/cudf/core/multiindex.py 92.14% <0.00%> (-0.02%) ⬇️
python/cudf/cudf/core/column/column.py 89.27% <0.00%> (ø)
python/dask_cudf/dask_cudf/__init__.py 82.35% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_orc.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_text.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/text.py 85.29% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40baeb4...f381414. Read the comment docs.

@randerzander randerzander requested a review from jdye64 March 22, 2022 00:39
@cwharris cwharris added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Mar 22, 2022
bdice
bdice reviewed Mar 22, 2022
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting the use of TextIOBase instead of StringIO, based on the usage. Otherwise LGTM.

edit: Should this target 22.06?

python/cudf/cudf/_lib/text.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_lib/text.pyx Outdated Show resolved Hide resolved
@cwharris cwharris requested a review from bdice March 22, 2022 19:28
bdice
bdice approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

python/cudf/cudf/tests/test_text.py Outdated Show resolved Hide resolved
jdye64
jdye64 approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@jdye64 jdye64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@cwharris
Copy link
Contributor Author

@gpucibot merge

@cwharris
Copy link
Contributor Author

rerun tests

1 similar comment
@cwharris
Copy link
Contributor Author

rerun tests

@cwharris
Copy link
Contributor Author

rerun tests

@rapids-bot rapids-bot bot merged commit 12b66a3 into rapidsai:branch-22.04 Mar 23, 2022
@cwharris cwharris deleted the read_text-stringio branch March 24, 2022 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@shwina shwina shwina approved these changes

@jdye64 jdye64 jdye64 approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cwharris @jdye64 @shwina @bdice