Fix default value of str.split expand parameter. #10457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
approved these changes
Mar 18, 2022
bdice
added
non-breaking
charlesbluca
approved these changes
Mar 21, 2022
|
rerun tests |
2 similar comments
|
rerun tests |
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10457 +/- ##
===============================================
Coverage ? 86.34%
===============================================
Files ? 140
Lines ? 22294
Branches ? 0
===============================================
Hits ? 19249
Misses ? 3045
Partials ? 0 Continue to review full report at Codecov.
|
galipremsagar
added
the
5 - Ready to Merge
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small fix to match the pandas API for the
expandparameter ofSeries.str.split. Only boolean values are allowed. Currently the default is set toNoneand then replaced with the intended default ofFalse. This PR changes it to have a default value ofFalse.This is a tiny bit of an API break because users who explicitly passed
Nonewill now see an error instead of getting the intended default value, but the previous behavior was a bug with respect to pandas API compatibility.