Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Java bindings for t-digest reduction #10446

Merged
merged 30 commits into from
Mar 25, 2022
Merged

Add Java bindings for t-digest reduction #10446

merged 30 commits into from
Mar 25, 2022

Conversation

andygrove
Copy link
Contributor

@andygrove andygrove commented Mar 16, 2022 •
edited
Loading

Adds JNI bindings for t-digest reductions (in commit 756ed20)

nvdbaranec and others added 24 commits February 22, 2022 11:44
@nvdbaranec
Add scan_aggregation and reduce_aggregations. C++ side only.
245e68c
@nvdbaranec
Java bindings.
c884d5c
@nvdbaranec
Merge branch 'branch-22.04' into scan_reduce_aggregations
321c9b2
@nvdbaranec
Python bindings.
900d55c
@nvdbaranec
Copyright updates.
0398a0d
@nvdbaranec
PR review comments.
a3a71b8
@nvdbaranec
Formatting
56a6c0f
@nvdbaranec
Centralize tdigest aggregation code to quantiles/tdigest.
8917445
@nvdbaranec
Clean up some test code.
e693562
@nvdbaranec
Merge branch 'scan_reduce_aggregations' into tdigest_code_move
f49e2c9
@nvdbaranec
Small test tweak.
23cae44
@nvdbaranec
Merge branch 'scan_reduce_aggregations' into tdigest_code_move
7fdc9f5
@nvdbaranec
tdigest reduce_aggregation functionality and tests.
3088ec8
@nvdbaranec
Merge branch 'branch-22.04' into scan_reduce_aggregations
6f940fd
@nvdbaranec
Merge branch 'scan_reduce_aggregations' into tdigest_code_move
13c776a
@nvdbaranec
Merge branch 'tdigest_code_move' into tdigest_reduction
3140f5f
@nvdbaranec
Merge branch 'branch-22.04' into tdigest_code_move
27a854e
@nvdbaranec
Copyright update.
6827e8f
@nvdbaranec
cmake format fixes.
25c1849
@nvdbaranec
Merge branch 'tdigest_code_move' into tdigest_reduction
b86b3db
@nvdbaranec
Merge branch 'branch-22.04' into tdigest_reduction
83f4d31
@nvdbaranec
Merge tdigest aggregation for cudf::reduce
6a2d50e
@nvdbaranec
Formatting fixes.
0fdd74e
@andygrove
Add JNI methods for tDigest reductions
1ab070c 
Signed-off-by: Andy Grove <[email protected]>
@andygrove andygrove added Java Affects Java cuDF API. 5 - DO NOT MERGE Hold off on merging; see PR for details labels Mar 16, 2022
@andygrove andygrove mentioned this pull request Mar 16, 2022
Merged
@github-actions github-actions bot added the CMake CMake build issue label Mar 16, 2022
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Mar 16, 2022
@andygrove andygrove changed the title WIP: Add Java bindings for t-digest reduction Add Java bindings for t-digest reduction Mar 23, 2022
@andygrove andygrove added 3 - Ready for Review Ready for review by team and removed 5 - DO NOT MERGE Hold off on merging; see PR for details labels Mar 23, 2022
@andygrove andygrove marked this pull request as ready for review March 23, 2022 16:20
@andygrove andygrove requested a review from a team as a code owner March 23, 2022 16:20
@mythrocks mythrocks added non-breaking Non-breaking change feature request New feature or request improvement Improvement / enhancement to an existing function and removed feature request New feature or request CMake CMake build issue labels Mar 23, 2022
@codecov
Copy link

codecov bot commented Mar 23, 2022 •
edited
Loading

Codecov Report

Merging #10446 (ba4fd8b) into branch-22.04 (54918d8) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head ba4fd8b differs from pull request most recent head 6a7455b. Consider uploading reports for the commit 6a7455b to get more accurate results

@@               Coverage Diff                @@
##           branch-22.04   #10446      +/-   ##
================================================
+ Coverage         86.15%   86.17%   +0.02%     
================================================
  Files               141      141              
  Lines             22510    22510              
================================================
+ Hits              19393    19398       +5     
+ Misses             3117     3112       -5
Impacted Files Coverage Δ
python/cudf/cudf/core/column/string.py 88.91% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.72% <0.00%> (+0.22%) ⬆️
python/cudf/cudf/core/column/numerical.py 95.62% <0.00%> (+0.29%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 90.69% <0.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4c450b...6a7455b. Read the comment docs.

@andygrove
Add test for merge tdigest
a249d1a 
Signed-off-by: Andy Grove <[email protected]>
@github-actions github-actions bot removed the libcudf Affects libcudf (C++/CUDA) code. label Mar 24, 2022
@andygrove andygrove added libcudf Affects libcudf (C++/CUDA) code. 5 - DO NOT MERGE Hold off on merging; see PR for details labels Mar 24, 2022
@github-actions github-actions bot removed the libcudf Affects libcudf (C++/CUDA) code. label Mar 24, 2022
@andygrove andygrove removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Mar 24, 2022
@ajschmidt8 ajschmidt8 merged commit c71fe1b into rapidsai:branch-22.04 Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mythrocks mythrocks mythrocks left review comments

@jlowe jlowe jlowe approved these changes

Assignees

@andygrove andygrove

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andygrove @jlowe @mythrocks @ajschmidt8 @nvdbaranec