Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dask_cudf imports to be compatible with latest dask #10442

Merged

Conversation

rlratzel
Copy link
Contributor

Updated imports to be compatible with latest dask after dask/dask#8796
This change is also compatible with dask versions prior to the above dask PR.

Tested import dask_cudf with both dask 2022.02.2a220314 and 2022.02.2a220315.

…(this change should also be compatible with dask version prior to that PR too)
@rlratzel rlratzel added bug Something isn't working non-breaking Non-breaking change labels Mar 16, 2022
@rlratzel rlratzel requested a review from a team as a code owner March 16, 2022 04:37
@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 16, 2022
@rlratzel rlratzel changed the title Updated dask_cudf imports to be compatible with latest dask Update dask_cudf imports to be compatible with latest dask Mar 16, 2022
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #10442 (806540c) into branch-22.04 (4596244) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           branch-22.04   #10442      +/-   ##
================================================
+ Coverage         86.13%   86.18%   +0.04%     
================================================
  Files               139      139              
  Lines             22438    22468      +30     
================================================
+ Hits              19328    19363      +35     
+ Misses             3110     3105       -5     
Impacted Files Coverage Δ
python/cudf/cudf/core/tools/numeric.py 89.24% <100.00%> (+0.11%) ⬆️
python/dask_cudf/dask_cudf/backends.py 86.44% <100.00%> (+1.47%) ⬆️
...ython/dask_cudf/dask_cudf/io/tests/test_parquet.py 100.00% <100.00%> (ø)
python/cudf/cudf/core/column/string.py 88.39% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.57% <0.00%> (+0.22%) ⬆️
python/cudf/cudf/core/column/numerical.py 95.28% <0.00%> (+0.29%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 90.56% <0.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1649955...806540c. Read the comment docs.

@shwina
Copy link
Contributor

shwina commented Mar 16, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d4ce5d5 into rapidsai:branch-22.04 Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants