-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove or split up Frame methods that use the index #10439
Remove or split up Frame methods that use the index #10439
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10439 +/- ##
================================================
+ Coverage 85.95% 86.15% +0.19%
================================================
Files 139 139
Lines 22435 22447 +12
================================================
+ Hits 19285 19340 +55
+ Misses 3150 3107 -43
Continue to review full report at Codecov.
|
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small comment below.
@gpucibot merge |
This PR contributes to excising indexes from Frame and moving them entirely to IndexedFrame. A number of methods (such as
copy
,equals
, and_mimic_inplace
) have either been removed fromFrame
or had the index-related logic moved to corresponding function overrides in IndexedFrame. In the process, this PR also implements certain optimizations as part of the rewrite. Of particular interest is that because indexes are immutable,IndexedFrame.copy
has been modified to always shallow copy the index, which should significantly reduce memory pressure in copy-heavy applications. This also results in significant performance improvements when the Index is not a RangeIndex, for example:Other methods rewritten in this PR have also been sped up, although the speedups are typically more modest. For example: