Fix has_null predicate for drop_list_duplicates on nested structs #10436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sperlingxx <[email protected]>
sperlingxx
added
bug
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10436 +/- ##
================================================
+ Coverage 86.13% 86.18% +0.04%
================================================
Files 139 139
Lines 22438 22470 +32
================================================
+ Hits 19328 19365 +37
+ Misses 3110 3105 -5
Continue to review full report at Codecov.
|
davidwendt
reviewed
Mar 15, 2022
| { | ||
| using ColWrapper = cudf::test::fixed_width_column_wrapper<TypeParam, int32_t>; | ||
| auto constexpr XXX = int32_t{0}; // nulls at the parent structs column level | ||
| auto constexpr YYY = int32_t{0}; // nulls at the parent structs column level |
There was a problem hiding this comment.
I'm struggling with the distinction between XXX and YYY here.
There was a problem hiding this comment.
@davidwendt Sorry, it is my blunder. They should be assigned with different values to create intra null structs with
children of different values.
ttnghia
reviewed
Mar 15, 2022
Co-authored-by: Nghia Truong <[email protected]>
Signed-off-by: sperlingxx <[email protected]>
ttnghia
reviewed
Mar 16, 2022
ttnghia
approved these changes
Mar 16, 2022
Co-authored-by: Nghia Truong <[email protected]>
|
@gpucibot rerun tests |
1 similar comment
|
@gpucibot rerun tests |
davidwendt
approved these changes
Mar 16, 2022
|
@gpucibot rerun tests |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now,
get_indices_of_unique_entries_dispatchonly checks the outest layer of structures to determine whether the column contains null or not. It leads to the omission of intra null structures.In current,
[Struct(Struct(1, "a", valid)), Struct(Struct(1, "a", valid), Struct(Struct(2, "a", invalid), Struct(Struct(1, "b", invalid)]becomes[Struct(Struct(1, "a", valid)), Struct(Struct(2, "a", invalid), Struct(Struct(1, "b", invalid)]after droping list duplicates even if null equality is EQUAL. However, it should be[Struct(Struct(1, "a", valid)), Struct(Struct(2, "a", invalid)], becauseStruct(1, "a")andStruct(2, "a")are both invalid, despite they contain different elements.Current PR is to fix above problem by checking all flattened coulumns for nulls.