Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty reduce with List output and non-List input #10435

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

sperlingxx
Copy link
Contributor

For certain aggregation operations, such as: collect_list or collect_set, their output types are List, while their input might not be List. We need to handcraft the the default scalar for this scenario, since make_default_constructed_scalar can not create list scalars.

@sperlingxx sperlingxx added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Mar 15, 2022
@sperlingxx sperlingxx requested a review from a team as a code owner March 15, 2022 08:15
@sperlingxx sperlingxx self-assigned this Mar 15, 2022
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #10435 (302cc5b) into branch-22.04 (0be0b00) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 302cc5b differs from pull request most recent head 909ef19. Consider uploading reports for the commit 909ef19 to get more accurate results

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04   #10435      +/-   ##
================================================
+ Coverage         86.13%   86.15%   +0.01%     
================================================
  Files               139      139              
  Lines             22438    22438              
================================================
+ Hits              19328    19331       +3     
+ Misses             3110     3107       -3     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/numerical.py 94.69% <0.00%> (-0.30%) ⬇️
python/cudf/cudf/core/column/string.py 88.39% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.57% <0.00%> (+0.22%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 90.56% <0.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4596244...909ef19. Read the comment docs.

@sperlingxx sperlingxx requested a review from mythrocks March 16, 2022 02:07
@sperlingxx
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 94e9f58 into rapidsai:branch-22.04 Mar 17, 2022
@sperlingxx sperlingxx deleted the fix_reduce branch March 17, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants