-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Fix error in cudf.to_numeric
when a bool
input is passed
#10431
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10431 +/- ##
================================================
+ Coverage 86.13% 86.16% +0.02%
================================================
Files 139 139
Lines 22438 22439 +1
================================================
+ Hits 19328 19334 +6
+ Misses 3110 3105 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks much cleaner. It does mean reconstructing the list any time cudf.to_numeric
is called with downcast=True
, but I'm fine with that.
@gpucibot merge |
Fixes: #10049
This PR fixes an incorrect error being displayed when
cudf.to_numeric
is called by passing an input withbool
dtype. Technicallybool
is the lowestdtype
size possible innumpy
so this is a no-op becauseto_numeric
is aimed at downcasting inputs.