Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmarks to work with new aggregation types #10428

Merged

Conversation

davidwendt
Copy link
Contributor

Fixes benchmarks compile errors introduced by #10357

Example:

/cudf/cpp/benchmarks/reduction/reduce.cpp: In function ‘void BM_reduction(benchmark::State&, const std::unique_ptr<cudf::aggregation>&)’:
/cudf/cpp/benchmarks/reduction/reduce.cpp:52:46: error: invalid initialization of reference of type ‘const std::unique_ptr<cudf::reduce_aggregation>&’ from expression of type ‘const std::unique_ptr<cudf::aggregation>’
   52 |     auto result = cudf::reduce(input_column, agg, output_dtype);

Aggregation types for reduce and scan were modified to include template types.

@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Mar 14, 2022
@davidwendt davidwendt requested a review from a team as a code owner March 14, 2022 13:45
@davidwendt davidwendt self-assigned this Mar 14, 2022
@davidwendt davidwendt requested review from trxcllnt and ttnghia March 14, 2022 13:45
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #10428 (6928347) into branch-22.04 (0be0b00) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04   #10428      +/-   ##
================================================
+ Coverage         86.13%   86.15%   +0.01%     
================================================
  Files               139      139              
  Lines             22438    22438              
================================================
+ Hits              19328    19332       +4     
+ Misses             3110     3106       -4     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/string.py 88.39% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.57% <0.00%> (+0.22%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 90.56% <0.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a066e7f...6928347. Read the comment docs.

@davidwendt davidwendt requested a review from nvdbaranec March 14, 2022 16:38
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I merged these changes locally and verified that they fix the build.

@vyasr
Copy link
Contributor

vyasr commented Mar 14, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 61772d8 into rapidsai:branch-22.04 Mar 14, 2022
@davidwendt davidwendt deleted the compile-benchmarks-new-agg branch March 15, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants