-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centralization of tdigest aggregation code. #10422
Centralization of tdigest aggregation code. #10422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CMake approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can't tell what's wrong with CMake style :\
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmake-format failed ;)
@gpucibot merge |
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10422 +/- ##
================================================
+ Coverage 86.13% 86.15% +0.01%
================================================
Files 139 139
Lines 22460 22438 -22
================================================
- Hits 19347 19332 -15
+ Misses 3113 3106 -7
Continue to review full report at Codecov.
|
This PR is prep-work for adding support for invoking the tdigest aggregations through
cudf::reduce
. It doesn't change any code, just moves some things around:groupby/sort/group_tdigest.cu
->quantiles/tdigest/tdigest_aggregation.cu
group_reductions.hpp
toquantiles/tdigest/tdigest.hpp
Doing this as a seperate PR so the actual changes for the reduction work show up as a reasonable diff.