Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralization of tdigest aggregation code. #10422

Merged
merged 17 commits into from
Mar 14, 2022

Conversation

nvdbaranec
Copy link
Contributor

This PR is prep-work for adding support for invoking the tdigest aggregations through cudf::reduce. It doesn't change any code, just moves some things around:

  • groupby/sort/group_tdigest.cu -> quantiles/tdigest/tdigest_aggregation.cu
  • Moves exposure of the aggregation functions from group_reductions.hpp to quantiles/tdigest/tdigest.hpp

Doing this as a seperate PR so the actual changes for the reduction work show up as a reasonable diff.

@nvdbaranec nvdbaranec added libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 11, 2022
@nvdbaranec nvdbaranec requested review from a team as code owners March 11, 2022 23:13
@nvdbaranec nvdbaranec requested review from vuule and codereport March 11, 2022 23:14
@github-actions github-actions bot added the CMake CMake build issue label Mar 11, 2022
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake approval.

Copy link
Contributor

@codereport codereport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@vuule vuule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Can't tell what's wrong with CMake style :\

Copy link
Contributor

@ttnghia ttnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake-format failed ;)

@nvdbaranec
Copy link
Contributor Author

@gpucibot merge

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #10422 (e79e3e6) into branch-22.04 (b613394) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head e79e3e6 differs from pull request most recent head 25c1849. Consider uploading reports for the commit 25c1849 to get more accurate results

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04   #10422      +/-   ##
================================================
+ Coverage         86.13%   86.15%   +0.01%     
================================================
  Files               139      139              
  Lines             22460    22438      -22     
================================================
- Hits              19347    19332      -15     
+ Misses             3113     3106       -7     
Impacted Files Coverage Δ
python/cudf/cudf/io/parquet.py 92.70% <ø> (ø)
python/cudf/cudf/core/column/column.py 89.16% <100.00%> (+0.17%) ⬆️
python/cudf/cudf/core/dataframe.py 93.57% <100.00%> (ø)
python/cudf/cudf/core/frame.py 91.72% <100.00%> (ø)
python/cudf/cudf/core/groupby/groupby.py 91.57% <100.00%> (+0.08%) ⬆️
python/cudf/cudf/core/single_column_frame.py 97.01% <100.00%> (ø)
python/cudf/cudf/core/column/string.py 88.39% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 90.56% <0.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1ea304...25c1849. Read the comment docs.

@rapids-bot rapids-bot bot merged commit cf936b6 into rapidsai:branch-22.04 Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants