-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Remove warnings in test_timedelta.py
#10418
Merged
rapids-bot
merged 6 commits into
rapidsai:branch-22.04
from
galipremsagar:test_timedelta
Mar 12, 2022
Merged
[REVIEW] Remove warnings in test_timedelta.py
#10418
rapids-bot
merged 6 commits into
rapidsai:branch-22.04
from
galipremsagar:test_timedelta
Mar 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
3 - Ready for Review
Ready for review by team
Python
Affects Python cuDF API.
4 - Needs cuDF (Python) Reviewer
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Mar 11, 2022
17 tasks
bdice
requested changes
Mar 11, 2022
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10418 +/- ##
================================================
+ Coverage 86.13% 86.16% +0.02%
================================================
Files 139 139
Lines 22460 22457 -3
================================================
+ Hits 19347 19351 +4
+ Misses 3113 3106 -7
Continue to review full report at Codecov.
|
bdice
approved these changes
Mar 12, 2022
@gpucibot merge |
bdice
added
5 - Ready to Merge
Testing and reviews complete, ready to merge
and removed
3 - Ready for Review
Ready for review by team
4 - Needs cuDF (Python) Reviewer
labels
Mar 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
5 - Ready to Merge
Testing and reviews complete, ready to merge
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Python
Affects Python cuDF API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #10363, by removing all warnings from
test_timedelta.py
.