Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Remove warnings in test_timedelta.py #10418

Merged
merged 6 commits into from
Mar 12, 2022

Conversation

galipremsagar
Copy link
Contributor

Partially addresses #10363, by removing all warnings from test_timedelta.py.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 11, 2022
@galipremsagar galipremsagar requested a review from bdice March 11, 2022 20:14
@galipremsagar galipremsagar requested a review from a team as a code owner March 11, 2022 20:14
@galipremsagar galipremsagar self-assigned this Mar 11, 2022
@galipremsagar galipremsagar requested a review from vyasr March 11, 2022 20:14
python/cudf/cudf/tests/test_timedelta.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_timedelta.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_timedelta.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #10418 (4dad344) into branch-22.04 (b613394) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04   #10418      +/-   ##
================================================
+ Coverage         86.13%   86.16%   +0.02%     
================================================
  Files               139      139              
  Lines             22460    22457       -3     
================================================
+ Hits              19347    19351       +4     
+ Misses             3113     3106       -7     
Impacted Files Coverage Δ
python/cudf/cudf/io/parquet.py 92.70% <ø> (ø)
python/cudf/cudf/core/column/column.py 89.16% <100.00%> (+0.17%) ⬆️
python/cudf/cudf/core/dataframe.py 93.57% <100.00%> (ø)
python/cudf/cudf/core/frame.py 91.72% <100.00%> (ø)
python/cudf/cudf/core/single_column_frame.py 97.01% <100.00%> (ø)
python/cudf/cudf/core/column/string.py 88.39% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.92% <0.00%> (+0.43%) ⬆️
python/cudf/cudf/core/column/lists.py 90.56% <0.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0f7fe6...4dad344. Read the comment docs.

@galipremsagar galipremsagar requested a review from bdice March 11, 2022 21:58
@bdice
Copy link
Contributor

bdice commented Mar 12, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2007480 into rapidsai:branch-22.04 Mar 12, 2022
@bdice bdice added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants