Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix some warnings in test_parquet.py #10416

Merged
merged 5 commits into from
Mar 11, 2022

Conversation

galipremsagar
Copy link
Contributor

Resolves part of #10363, there still are some warnings remaining, which I tried to resolve and went down a rabbit hole of a bug inside pyarrow<->pandas conversions so will take it up later.

@galipremsagar galipremsagar added Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 11, 2022
@galipremsagar galipremsagar requested a review from bdice March 11, 2022 17:59
@galipremsagar galipremsagar self-assigned this Mar 11, 2022
@galipremsagar galipremsagar requested a review from a team as a code owner March 11, 2022 17:59
@galipremsagar galipremsagar requested a review from shwina March 11, 2022 17:59
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed one small commit to add a missing space to the warning string being caught here. I also have one suggestion for de-duplication of the warning handling logic. Either way, this looks good to me. Thanks!

python/cudf/cudf/tests/test_parquet.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_parquet.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #10416 (79be08c) into branch-22.04 (b613394) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 79be08c differs from pull request most recent head 2019bad. Consider uploading reports for the commit 2019bad to get more accurate results

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04   #10416      +/-   ##
================================================
+ Coverage         86.13%   86.16%   +0.02%     
================================================
  Files               139      139              
  Lines             22460    22457       -3     
================================================
+ Hits              19347    19351       +4     
+ Misses             3113     3106       -7     
Impacted Files Coverage Δ
python/cudf/cudf/io/parquet.py 92.70% <ø> (ø)
python/cudf/cudf/core/column/column.py 89.16% <100.00%> (+0.17%) ⬆️
python/cudf/cudf/core/dataframe.py 93.57% <100.00%> (ø)
python/cudf/cudf/core/frame.py 91.72% <100.00%> (ø)
python/cudf/cudf/core/single_column_frame.py 97.01% <100.00%> (ø)
python/cudf/cudf/core/column/string.py 88.39% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.92% <0.00%> (+0.43%) ⬆️
python/cudf/cudf/core/column/lists.py 90.56% <0.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0f7fe6...2019bad. Read the comment docs.

@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f29c8d9 into rapidsai:branch-22.04 Mar 11, 2022
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 4 - Needs cuDF (Python) Reviewer labels Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants