-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Fix some warnings in test_parquet.py
#10416
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed one small commit to add a missing space to the warning string being caught here. I also have one suggestion for de-duplication of the warning handling logic. Either way, this looks good to me. Thanks!
Co-authored-by: Bradley Dice <[email protected]>
…into test_parquet
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10416 +/- ##
================================================
+ Coverage 86.13% 86.16% +0.02%
================================================
Files 139 139
Lines 22460 22457 -3
================================================
+ Hits 19347 19351 +4
+ Misses 3113 3106 -7
Continue to review full report at Codecov.
|
@gpucibot merge |
Resolves part of #10363, there still are some warnings remaining, which I tried to resolve and went down a rabbit hole of a bug inside pyarrow<->pandas conversions so will take it up later.