-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cudf::shift to handle offset greater than column size #10414
Fix cudf::shift to handle offset greater than column size #10414
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10414 +/- ##
================================================
+ Coverage 86.13% 86.15% +0.01%
================================================
Files 139 139
Lines 22438 22434 -4
================================================
+ Hits 19328 19329 +1
+ Misses 3110 3105 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@gpucibot merge |
Closes #10314
Fixes logic to handle
abs(offset) > input.size()
when passed tocudf::shift
. As mentioned in #10314 this was causing an unexpected exception:The behavior now fills the entire output column with the input scalar value. If the scalar is null, then the column is filled with null entries. The logic added here did not require changing or adding any new kernel functions. Additional gtests were added to
shift_tests.cpp
as well.