Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JNI support for segmented reduce #10413

Merged
merged 2 commits into from
Mar 14, 2022

Conversation

revans2
Copy link
Contributor

@revans2 revans2 commented Mar 11, 2022

This adds in JNI support for #9621. It also adds in a helper API to allow us to do the processing on a list easily.

@revans2 revans2 added 3 - Ready for Review Ready for review by team Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS 4 - Needs cuDF (Java) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 11, 2022
@revans2 revans2 requested a review from a team as a code owner March 11, 2022 16:50
@revans2 revans2 self-assigned this Mar 11, 2022
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #10413 (e17f4dc) into branch-22.04 (b613394) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04   #10413      +/-   ##
================================================
+ Coverage         86.13%   86.16%   +0.02%     
================================================
  Files               139      139              
  Lines             22460    22457       -3     
================================================
+ Hits              19347    19351       +4     
+ Misses             3113     3106       -7     
Impacted Files Coverage Δ
python/cudf/cudf/core/frame.py 91.72% <0.00%> (ø)
python/cudf/cudf/core/single_column_frame.py 97.01% <0.00%> (ø)
python/cudf/cudf/core/column/string.py 88.39% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/column/column.py 89.16% <0.00%> (+0.17%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.92% <0.00%> (+0.43%) ⬆️
python/cudf/cudf/core/column/lists.py 90.56% <0.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbc4d8b...e17f4dc. Read the comment docs.

@firestarman
Copy link
Contributor

LGTM

@jlowe
Copy link
Member

jlowe commented Mar 14, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a066e7f into rapidsai:branch-22.04 Mar 14, 2022
@revans2 revans2 deleted the jni_segmented_reduce branch March 14, 2022 15:55
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants