Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up null mask after purging null entries #10412

Merged
merged 2 commits into from
Mar 12, 2022

Conversation

sperlingxx
Copy link
Contributor

After puring null entries via copy_if, the null mask of the input column will be preversed, despite it is useless. We can clean up the unused null mask to save some device memory.

@sperlingxx sperlingxx requested a review from ttnghia March 11, 2022 07:05
@sperlingxx sperlingxx requested a review from a team as a code owner March 11, 2022 07:05
@sperlingxx sperlingxx requested a review from jrhemstad March 11, 2022 07:05
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Mar 11, 2022
@sperlingxx sperlingxx added improvement Improvement / enhancement to an existing function 3 - Ready for Review Ready for review by team non-breaking Non-breaking change and removed libcudf Affects libcudf (C++/CUDA) code. labels Mar 11, 2022
@sperlingxx sperlingxx added the libcudf Affects libcudf (C++/CUDA) code. label Mar 11, 2022
Signed-off-by: sperlingxx <[email protected]>
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #10412 (57ecb1c) into branch-22.04 (b3dc9d6) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 57ecb1c differs from pull request most recent head 2a36168. Consider uploading reports for the commit 2a36168 to get more accurate results

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04   #10412      +/-   ##
================================================
+ Coverage         86.12%   86.16%   +0.03%     
================================================
  Files               139      139              
  Lines             22450    22460      +10     
================================================
+ Hits              19336    19352      +16     
+ Misses             3114     3108       -6     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/string.py 88.39% <ø> (+0.10%) ⬆️
python/cudf/cudf/core/column/column.py 88.99% <100.00%> (-0.02%) ⬇️
python/cudf/cudf/core/column/datetime.py 89.07% <100.00%> (-0.05%) ⬇️
python/cudf/cudf/core/column/numerical.py 94.98% <100.00%> (+0.29%) ⬆️
python/cudf/cudf/core/dataframe.py 93.57% <100.00%> (+<0.01%) ⬆️
python/cudf/cudf/core/frame.py 91.72% <100.00%> (ø)
python/cudf/cudf/core/groupby/groupby.py 91.92% <100.00%> (+0.41%) ⬆️
python/cudf/cudf/core/index.py 92.19% <100.00%> (+<0.01%) ⬆️
python/cudf/cudf/core/indexed_frame.py 92.25% <100.00%> (ø)
python/cudf/cudf/core/multiindex.py 92.13% <100.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46ac622...2a36168. Read the comment docs.

@sperlingxx
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit da55f6a into rapidsai:branch-22.04 Mar 12, 2022
@sperlingxx sperlingxx deleted the cleanup_unused_masks branch March 12, 2022 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants