Drop unsupported method argument from nunique and distinct_count. #10411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
Python
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10411 +/- ##
================================================
+ Coverage 86.13% 86.16% +0.02%
================================================
Files 139 139
Lines 22460 22457 -3
================================================
+ Hits 19347 19350 +3
+ Misses 3113 3107 -6
Continue to review full report at Codecov.
|
galipremsagar
approved these changes
Mar 11, 2022
galipremsagar
added
the
5 - Ready to Merge
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The APIs
DataFrame.nunique,Series.nunique, andColumnBase.distinct_counthave amethodargument. The pandas API fornuniquedoes not have amethodargument. Thismethodargument was meant to distinguish distinct counts computed by sort/hash approaches, but there are two issues: only"sort"is supported as an input value, and the algorithm in libcudf actually uses a hash-based approach. To resolve this inconsistency and align with the pandas API, I have removed themethodparameter fromDataFrame.nunique,Series.nunique, andColumnBase.distinct_count.This is a breaking change but I don't think a deprecation is needed. The
nuniquefeature was added in 22.04 via #10077, so it has not yet been released. The internal changes todistinct_countcan be made without a deprecation.