Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Enable codecov github-check in CI #10404

Merged
merged 8 commits into from
Mar 10, 2022
Merged

[REVIEW] Enable codecov github-check in CI #10404

merged 8 commits into from
Mar 10, 2022

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Mar 9, 2022 •
edited
Loading

This PR enables github-check for codecov that annotates code changes that are not being covered in pytests.

@galipremsagar galipremsagar requested a review from a team as a code owner March 9, 2022 15:58
@galipremsagar galipremsagar requested review from shwina and bdice March 9, 2022 15:58
@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 9, 2022
@galipremsagar galipremsagar added 5 - DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed Python Affects Python cuDF API. labels Mar 9, 2022
@codecov
Copy link

codecov bot commented Mar 9, 2022 •
edited
Loading

Codecov Report

Merging #10404 (f4f2989) into branch-22.04 (b3dc9d6) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head f4f2989 differs from pull request most recent head d93cc4f. Consider uploading reports for the commit d93cc4f to get more accurate results

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04   #10404      +/-   ##
================================================
+ Coverage         86.12%   86.16%   +0.03%     
================================================
  Files               139      139              
  Lines             22450    22465      +15     
================================================
+ Hits              19336    19357      +21     
+ Misses             3114     3108       -6
Impacted Files Coverage Δ
python/cudf/cudf/core/column/numerical.py 94.98% <100.00%> (+0.29%) ⬆️
python/cudf/cudf/core/dataframe.py 93.57% <100.00%> (+<0.01%) ⬆️
python/cudf/cudf/core/frame.py 91.73% <100.00%> (+<0.01%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.92% <100.00%> (+0.41%) ⬆️
python/cudf/cudf/core/index.py 92.19% <100.00%> (+<0.01%) ⬆️
python/cudf/cudf/core/indexed_frame.py 92.25% <100.00%> (ø)
python/cudf/cudf/core/multiindex.py 92.13% <100.00%> (ø)
python/cudf/cudf/core/series.py 95.16% <100.00%> (-0.01%) ⬇️
python/cudf/cudf/core/single_column_frame.py 97.03% <100.00%> (-0.03%) ⬇️
python/cudf/cudf/core/udf/utils.py 98.63% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46ac622...d93cc4f. Read the comment docs.

@galipremsagar galipremsagar reopened this Mar 9, 2022
@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 9, 2022
@galipremsagar galipremsagar removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Mar 9, 2022
@galipremsagar galipremsagar added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Mar 10, 2022
@bdice
Copy link
Contributor

bdice commented Mar 10, 2022

Evidence that the annotations are working:
image

Thanks @galipremsagar! This is so handy!

bdice
bdice approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving - revert the utils.py changes and we're good to merge.

galipremsagar
galipremsagar commented Mar 10, 2022
View reviewed changes
python/cudf/cudf/utils/utils.py Outdated Show resolved Hide resolved
python/cudf/cudf/utils/utils.py Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the Python Affects Python cuDF API. label Mar 10, 2022
@galipremsagar galipremsagar changed the title [DONOT MERGE] Codecov test [REVIEW] Enable codecov github-check in CI Mar 10, 2022
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 5 - DO NOT MERGE Hold off on merging; see PR for details labels Mar 10, 2022
@galipremsagar galipremsagar self-assigned this Mar 10, 2022
@galipremsagar
Copy link
Contributor Author

Evidence that the annotations are working: image

Thanks @galipremsagar! This is so handy!

cc: @ajschmidt8

@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit dbe7b4f into rapidsai:branch-22.04 Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@shwina shwina Awaiting requested review from shwina shwina was automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galipremsagar @bdice