Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error thrown in compiled-binaryop benchmark #10398

Merged

Conversation

davidwendt
Copy link
Contributor

Fixes BINARYOP_BENCH which is throwing an error for non-numeric types:

terminate called after throwing an instance of 'cudf::logic_error'
  what():  cuDF failure at: /cudf/cpp/src/filling/sequence.cu:139: init scalar type must be numeric

The compiled_binaryop.cpp was recently changed in #10300 to create test columns using the benchmark utility create_sequence_table which internally calls cudf::sequence API. Unfortunately, only numeric types can be used with this API which throws an error for types like timestamp, duration, and decimal which are being measured in this file. https://docs.rapids.ai/api/libcudf/stable/group__transformation__fill.html#gaeda630c9dcdd152eeecf0a1b636244ac

The fix replaces the create_sequence_table call with create_random_table to generate the source columns instead.

@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Mar 8, 2022
@davidwendt davidwendt requested a review from a team as a code owner March 8, 2022 16:09
@davidwendt davidwendt self-assigned this Mar 8, 2022
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #10398 (88e7b11) into branch-22.04 (5207eff) will increase coverage by 75.62%.
The diff coverage is n/a.

❗ Current head 88e7b11 differs from pull request most recent head 1dace28. Consider uploading reports for the commit 1dace28 to get more accurate results

Impacted file tree graph

@@                Coverage Diff                @@
##           branch-22.04   #10398       +/-   ##
=================================================
+ Coverage         10.50%   86.13%   +75.62%     
=================================================
  Files               127      139       +12     
  Lines             21200    22433     +1233     
=================================================
+ Hits               2228    19323    +17095     
+ Misses            18972     3110    -15862     
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/tests/test_groupby.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/tests/test_core.py 95.15% <0.00%> (ø)
...ython/dask_cudf/dask_cudf/tests/test_delayed_io.py 99.03% <0.00%> (ø)
python/dask_cudf/dask_cudf/tests/test_onehot.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/tests/test_accessor.py 98.41% <0.00%> (ø)
...ython/dask_cudf/dask_cudf/tests/test_reductions.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/tests/test_sort.py 100.00% <0.00%> (ø)
...thon/dask_cudf/dask_cudf/tests/test_distributed.py 86.79% <0.00%> (ø)
python/dask_cudf/dask_cudf/tests/test_dispatch.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/tests/test_binops.py 92.59% <0.00%> (ø)
... and 96 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5207eff...1dace28. Read the comment docs.

@davidwendt davidwendt requested a review from karthikeyann March 8, 2022 18:03
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks for doing this.
This fix is already part of PR #10109

@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 78eda63 into rapidsai:branch-22.04 Mar 9, 2022
@davidwendt davidwendt deleted the bug-binaryop-benchmark branch March 9, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants