Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

part1: Simplify BaseIndex to an abstract class #10389

Merged
merged 67 commits into from
Oct 6, 2022

Conversation

skirui-source
Copy link
Contributor

This PR is in response to @vyasr comment, as partial fix for PR #9593 :

BaseIndex should be reduced as closely as possible to an abstract class. While there are a subset of APIs that truly make sense for all types of index objects, in almost all cases the optimal implementation for RangeIndex (and MultiIndex, for that matter) is very different from the implementation for GenericIndex. In addition, this change reduces cognitive load for developers by simplifying the inheritance hierarchy

@skirui-source skirui-source added Python Affects Python cuDF API. Performance Performance related issue non-breaking Non-breaking change labels Mar 2, 2022
@skirui-source skirui-source self-assigned this Mar 2, 2022
@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Base: 87.40% // Head: 87.49% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (33c54c2) compared to base (f72c4ce).
Patch coverage: 84.48% of modified lines in pull request are covered.

❗ Current head 33c54c2 differs from pull request most recent head 407a2cc. Consider uploading reports for the commit 407a2cc to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #10389      +/-   ##
================================================
+ Coverage         87.40%   87.49%   +0.08%     
================================================
  Files               133      133              
  Lines             21833    21864      +31     
================================================
+ Hits              19084    19129      +45     
+ Misses             2749     2735      -14     
Impacted Files Coverage Δ
python/cudf/cudf/core/udf/__init__.py 50.00% <ø> (ø)
python/cudf/cudf/utils/ioutils.py 79.47% <ø> (ø)
...thon/dask_cudf/dask_cudf/tests/test_distributed.py 18.86% <ø> (+4.94%) ⬆️
python/cudf/cudf/core/_base_index.py 82.20% <43.75%> (-3.35%) ⬇️
python/strings_udf/strings_udf/__init__.py 86.27% <76.00%> (-10.61%) ⬇️
python/cudf/cudf/core/index.py 92.91% <95.08%> (+0.27%) ⬆️
python/cudf/cudf/__init__.py 90.69% <100.00%> (ø)
python/cudf/cudf/core/column/categorical.py 89.34% <100.00%> (ø)
python/cudf/cudf/core/scalar.py 90.52% <100.00%> (+1.25%) ⬆️
python/dask_cudf/dask_cudf/sorting.py 93.29% <100.00%> (+2.11%) ⬆️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skirui-source skirui-source changed the base branch from branch-22.04 to branch-22.06 March 30, 2022 00:42
@github-actions
Copy link

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@skirui-source skirui-source changed the base branch from branch-22.06 to branch-22.08 May 26, 2022 07:28
@skirui-source skirui-source added breaking Breaking change and removed non-breaking Non-breaking change inactive-30d labels Jul 28, 2022
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two very minor comments that I would have been fine punting on, but there's a small bug in any that needs to get fixed so let's just address all the comments before merging. At this point I would retarget to 22.12 since we're in code freeze, but we should be able to merge this very soon.

python/cudf/cudf/core/index.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/index.py Show resolved Hide resolved
python/cudf/cudf/core/_base_index.py Outdated Show resolved Hide resolved
@skirui-source skirui-source changed the base branch from branch-22.10 to branch-22.12 October 5, 2022 23:26
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for all the iterations.

@skirui-source skirui-source removed the 2 - In Progress Currently a work in progress label Oct 5, 2022
@skirui-source
Copy link
Contributor Author

@gpucibot rerun tests

@skirui-source
Copy link
Contributor Author

skirui-source commented Oct 6, 2022

@vyasr @mroeschke , need your eyes on this pr, the codecov/patch check keeps failing despite having added said tests cases.. is this a block to merging?

@vyasr
Copy link
Contributor

vyasr commented Oct 6, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e20eb94 into rapidsai:branch-22.12 Oct 6, 2022
@skirui-source skirui-source deleted the BaseIndex_simplify branch October 6, 2022 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change improvement Improvement / enhancement to an existing function Performance Performance related issue Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants