-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
part1: Simplify BaseIndex to an abstract class #10389
part1: Simplify BaseIndex to an abstract class #10389
Conversation
Codecov ReportBase: 87.40% // Head: 87.49% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #10389 +/- ##
================================================
+ Coverage 87.40% 87.49% +0.08%
================================================
Files 133 133
Lines 21833 21864 +31
================================================
+ Hits 19084 19129 +45
+ Misses 2749 2735 -14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…BaseIndex_simplify
…BaseIndex_simplify
This PR has been labeled |
…to BaseIndex_simplify
…BaseIndex_simplify
…BaseIndex_simplify
… silence mypy erros and failing tests
…BaseIndex_simplify
…BaseIndex_simplify
…to BaseIndex_simplify
…BaseIndex_simplify
…BaseIndex_simplify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have two very minor comments that I would have been fine punting on, but there's a small bug in any
that needs to get fixed so let's just address all the comments before merging. At this point I would retarget to 22.12 since we're in code freeze, but we should be able to merge this very soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for all the iterations.
@gpucibot rerun tests |
@vyasr @mroeschke , need your eyes on this pr, the |
@gpucibot merge |
This PR is in response to @vyasr comment, as partial fix for PR #9593 :
BaseIndex
should be reduced as closely as possible to an abstract class. While there are a subset of APIs that truly make sense for all types of index objects, in almost all cases the optimal implementation forRangeIndex
(andMultiIndex
, for that matter) is very different from the implementation forGenericIndex
. In addition, this change reduces cognitive load for developers by simplifying the inheritance hierarchy