Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include <optional> in multibyte split. #10385

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Mar 2, 2022

#10150 broke compiler support for GCC 11 (built locally) because it was missing #include <optional> in a couple files. This fixes it. cc: @cwharris

@bdice bdice requested a review from a team as a code owner March 2, 2022 17:18
@bdice bdice requested review from harrism and karthikeyann March 2, 2022 17:18
@bdice bdice self-assigned this Mar 2, 2022
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Mar 2, 2022
@bdice bdice added bug Something isn't working non-breaking Non-breaking change labels Mar 2, 2022
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #10385 (c06a778) into branch-22.04 (a7d88cd) will decrease coverage by 0.56%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04   #10385      +/-   ##
================================================
- Coverage         10.42%    9.85%   -0.57%     
================================================
  Files               119      126       +7     
  Lines             20603    22606    +2003     
================================================
+ Hits               2148     2228      +80     
- Misses            18455    20378    +1923     
Impacted Files Coverage Δ
...ython/custreamz/custreamz/tests/test_dataframes.py 99.39% <0.00%> (-0.01%) ⬇️
python/cudf/cudf/errors.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/ops.py 0.00% <0.00%> (ø)
python/cudf/cudf/datasets.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/scalar.py 0.00% <0.00%> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1217f24...c06a778. Read the comment docs.

@karthikeyann
Copy link
Contributor

rerun tests

@bdice
Copy link
Contributor Author

bdice commented Mar 2, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit fbac0ac into rapidsai:branch-22.04 Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants