Consolidate some Frame APIs #10381
Merged
Consolidate some Frame APIs #10381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10381 +/- ##
=============================================
Coverage 10.50% 10.50%
=============================================
Files 126 126
Lines 21218 21206 -12
=============================================
Hits 2228 2228
+ Misses 18990 18978 -12
Continue to review full report at Codecov.
|
vyasr
force-pushed
the
refactor/frame_api_consolidation
branch
from
893f4dd to
e35b82b
Compare
…e_api_consolidation # Conflicts: # python/cudf/cudf/core/index.py # python/cudf/cudf/core/multiindex.py # python/cudf/cudf/core/series.py
galipremsagar
approved these changes
Mar 7, 2022
|
@gpucibot merge |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to #9038 by combining common code for
append,astype,drop, andexplode. It's not a small LOC change, but most of the changed lines are just moving code around. Some minor rewrites ofastypein this PR do significantly speed up those calls (2x faster for <1M rows). Additionally, I've deprecatedappendsince it is now deprecated in pandas. Note that it has not been removed in pandas, so we should not remove it until they do.