Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix issue with column and scalar re-assignment #10377

Merged
merged 2 commits into from
Mar 2, 2022

Conversation

galipremsagar
Copy link
Contributor

Fixes: #10305 This PR fixes issues where the scalar that is being assigned was being type-casted to the column's type. Added test coverage for the same.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Mar 1, 2022
@galipremsagar galipremsagar requested a review from a team as a code owner March 1, 2022 21:36
@galipremsagar galipremsagar requested a review from isVoid March 1, 2022 21:36
@galipremsagar galipremsagar self-assigned this Mar 1, 2022
@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 1, 2022
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #10377 (b9c9091) into branch-22.04 (78b316c) will increase coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04   #10377      +/-   ##
================================================
+ Coverage         10.58%   10.64%   +0.06%     
================================================
  Files               125      126       +1     
  Lines             21058    20938     -120     
================================================
  Hits               2228     2228              
+ Misses            18830    18710     -120     
Impacted Files Coverage Δ
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/scalar.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/indexed_frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/mixins/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/mixins/mixin_factory.py 0.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78b316c...b9c9091. Read the comment docs.

python/cudf/cudf/core/dataframe.py Outdated Show resolved Hide resolved
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Mar 2, 2022
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6bcfc10 into rapidsai:branch-22.04 Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Reassigning dataframe column to a scalar preserves the stale dtype
2 participants