Support Java bindings for Avro reader #10373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
|
Can one of the admins verify this patch? |
sperlingxx
added
non-breaking
wbo4958
reviewed
Mar 1, 2022
| @@ -1020,6 +1031,85 @@ public static Table readParquet(ParquetOptions opts, HostMemoryBuffer buffer, | |||
| null, buffer.getAddress() + offset, len, opts.timeUnit().typeId.getNativeId())); | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
please delete redundant blank line
wbo4958
reviewed
Mar 1, 2022
| null, buffer.getAddress() + offset, len)); | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
please delete redundant blank line
|
LGTM |
wbo4958
approved these changes
Mar 1, 2022
jlowe
reviewed
Mar 1, 2022
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
firestarman
reviewed
Mar 2, 2022
firestarman
reviewed
Mar 2, 2022
|
rerun tests |
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
|
LGTM |
|
rerun tests |
firestarman
added
3 - Ready for Review
|
ok to test |
Thank you very much ! |
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10373 +/- ##
================================================
- Coverage 10.63% 8.98% -1.65%
================================================
Files 122 126 +4
Lines 20953 24786 +3833
================================================
Hits 2228 2228
- Misses 18725 22558 +3833
Continue to review full report at Codecov.
|
jlowe
approved these changes
Mar 2, 2022
|
rerun tests |
firestarman
added
5 - Ready to Merge
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we add Avro reader JNI and some reader options in cudf java.
Re NVIDIA/spark-rapids#4831