Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor filling.repeat API #10371

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Mar 1, 2022

Part of #10153

This PR refactors filling.repeat cython API to accept a list of columns instead of Frame object. In this PR I'm also trying out a possibly better pattern for index and indexed_frame to share logics, which might become a solution for #10068.

@isVoid isVoid added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 1, 2022
@isVoid isVoid requested a review from vyasr March 1, 2022 01:26
@isVoid isVoid requested a review from a team as a code owner March 1, 2022 01:26
@isVoid isVoid requested a review from shwina March 1, 2022 01:26
@isVoid isVoid self-assigned this Mar 1, 2022
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

python/cudf/cudf/core/indexed_frame.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/_base_index.py Outdated Show resolved Hide resolved
Co-authored-by: Vyas Ramasubramani <[email protected]>
@vyasr
Copy link
Contributor

vyasr commented Mar 2, 2022

rerun tests

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #10371 (677a7a2) into branch-22.04 (b613394) will decrease coverage by 0.12%.
The diff coverage is 95.23%.

@@               Coverage Diff                @@
##           branch-22.04   #10371      +/-   ##
================================================
- Coverage         86.13%   86.01%   -0.13%     
================================================
  Files               139      139              
  Lines             22460    22435      -25     
================================================
- Hits              19347    19298      -49     
- Misses             3113     3137      +24     
Impacted Files Coverage Δ
python/cudf/cudf/core/dataframe.py 93.57% <ø> (ø)
python/cudf/cudf/io/parquet.py 92.70% <ø> (ø)
python/cudf/cudf/core/_base_index.py 86.21% <50.00%> (-0.22%) ⬇️
python/cudf/cudf/core/column/column.py 89.27% <100.00%> (+0.28%) ⬆️
python/cudf/cudf/core/frame.py 91.82% <100.00%> (+0.10%) ⬆️
python/cudf/cudf/core/index.py 92.22% <100.00%> (+0.02%) ⬆️
python/cudf/cudf/core/indexed_frame.py 92.30% <100.00%> (+0.04%) ⬆️
python/cudf/cudf/core/multiindex.py 92.15% <100.00%> (+0.02%) ⬆️
python/cudf/cudf/core/single_column_frame.py 97.01% <100.00%> (ø)
...thon/dask_cudf/dask_cudf/tests/test_distributed.py 18.86% <0.00%> (-67.93%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f29c8d9...677a7a2. Read the comment docs.

@isVoid
Copy link
Contributor Author

isVoid commented Mar 11, 2022

rerun tests

@isVoid
Copy link
Contributor Author

isVoid commented Mar 18, 2022

rerun tests

1 similar comment
@isVoid
Copy link
Contributor Author

isVoid commented Mar 18, 2022

rerun tests

@isVoid
Copy link
Contributor Author

isVoid commented Mar 18, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 47d16cb into rapidsai:branch-22.04 Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants