-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor filling.repeat
API
#10371
Refactor filling.repeat
API
#10371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Vyas Ramasubramani <[email protected]>
…m:isVoid/cudf into improvement/ListOfColumnsRefactor/filling
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10371 +/- ##
================================================
- Coverage 86.13% 86.01% -0.13%
================================================
Files 139 139
Lines 22460 22435 -25
================================================
- Hits 19347 19298 -49
- Misses 3113 3137 +24
Continue to review full report at Codecov.
|
…m:isVoid/cudf into improvement/ListOfColumnsRefactor/filling
…ent/ListOfColumnsRefactor/filling
…ent/ListOfColumnsRefactor/filling
rerun tests |
…ent/ListOfColumnsRefactor/filling
rerun tests |
1 similar comment
rerun tests |
@gpucibot merge |
Part of #10153
This PR refactors
filling.repeat
cython API to accept a list of columns instead of Frame object. In this PR I'm also trying out a possibly better pattern for index and indexed_frame to share logics, which might become a solution for #10068.