Move standalone UTF8 functions from string_view.hpp to utf8.hpp #10369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10369 +/- ##
=============================================
Coverage 10.58% 10.58%
=============================================
Files 125 125
Lines 21058 21058
=============================================
Hits 2228 2228
Misses 18830 18830 Continue to review full report at Codecov.
|
davidwendt
changed the title
davidwendt
added
3 - Ready for Review
ajschmidt8
approved these changes
Mar 2, 2022
ttnghia
approved these changes
Mar 7, 2022
|
@gpucibot merge |
1 similar comment
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move some standalone UTF8 functions that were defined in
string_view.hppto a newdetails/utf8.hpp. While working on #10270 and reworking some regex utilities, the standalone functions are useful without needing to include thestring_viewclass definition. These can be included and used in.cpphost source files as needed as well.This is purely for cleanup and convenience. No actual functions have been added, updated or removed.