Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove doc for deprecated function one_hot_encoding #10367

Merged

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Feb 28, 2022

This PR removes doc item for deprecated function one_hot_encoding.

@isVoid isVoid self-assigned this Feb 28, 2022
@isVoid isVoid added deprecation non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Feb 28, 2022
@isVoid isVoid requested a review from bdice February 28, 2022 18:28
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caught something after approving. Let's fix the header text to match pandas - we no longer have "encoding" and can match the pandas header name.

docs/cudf/source/api_docs/series.rst Show resolved Hide resolved
@isVoid isVoid requested a review from bdice February 28, 2022 18:46
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the heading underlines and this is good to go! Thanks @isVoid!

docs/cudf/source/api_docs/dataframe.rst Outdated Show resolved Hide resolved
docs/cudf/source/api_docs/series.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can merge once @bdice approves.

@isVoid
Copy link
Contributor Author

isVoid commented Feb 28, 2022

@gpucibot merge

@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #10367 (9358387) into branch-22.04 (a7d88cd) will increase coverage by 0.15%.
The diff coverage is n/a.

❗ Current head 9358387 differs from pull request most recent head aeae195. Consider uploading reports for the commit aeae195 to get more accurate results

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04   #10367      +/-   ##
================================================
+ Coverage         10.42%   10.58%   +0.15%     
================================================
  Files               119      125       +6     
  Lines             20603    21058     +455     
================================================
+ Hits               2148     2228      +80     
- Misses            18455    18830     +375     
Impacted Files Coverage Δ
...ython/custreamz/custreamz/tests/test_dataframes.py 99.39% <0.00%> (-0.01%) ⬇️
python/cudf/cudf/errors.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/ops.py 0.00% <0.00%> (ø)
python/cudf/cudf/datasets.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 619b2c7...aeae195. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 87a2ea4 into rapidsai:branch-22.04 Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants