-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a mixin for binops #10360
Merged
rapids-bot
merged 10 commits into
rapidsai:branch-22.04
from
vyasr:refactor/binops_mixin
Mar 2, 2022
Merged
Implement a mixin for binops #10360
rapids-bot
merged 10 commits into
rapidsai:branch-22.04
from
vyasr:refactor/binops_mixin
Mar 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… process op names.
vyasr
added
3 - Ready for Review
Ready for review by team
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Feb 25, 2022
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10360 +/- ##
================================================
+ Coverage 10.42% 10.61% +0.18%
================================================
Files 119 126 +7
Lines 20603 20993 +390
================================================
+ Hits 2148 2228 +80
- Misses 18455 18765 +310
Continue to review full report at Codecov.
|
shwina
reviewed
Feb 28, 2022
shwina
reviewed
Feb 28, 2022
…t of supported operations.
isVoid
approved these changes
Mar 1, 2022
shwina
approved these changes
Mar 2, 2022
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Python
Affects Python cuDF API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the framework introduced in #9925 to implement scans. I plan to apply this mixin to ColumnBase as well, but that will require more work to clean up binary operations for column types and it is large enough to merit a separate PR.
Contributes to #10177.