Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a mixin for binops #10360

Merged
merged 10 commits into from
Mar 2, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Feb 25, 2022

This PR builds on the framework introduced in #9925 to implement scans. I plan to apply this mixin to ColumnBase as well, but that will require more work to clean up binary operations for column types and it is large enough to merit a separate PR.

Contributes to #10177.

@vyasr vyasr requested a review from a team as a code owner February 25, 2022 21:49
@vyasr vyasr requested review from isVoid and charlesbluca February 25, 2022 21:49
@vyasr vyasr self-assigned this Feb 25, 2022
@github-actions github-actions bot added the Python Affects Python cuDF API. label Feb 25, 2022
@vyasr vyasr added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 25, 2022
@vyasr vyasr added this to the CuDF Python Refactoring milestone Feb 25, 2022
@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #10360 (4ba4db9) into branch-22.04 (a7d88cd) will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04   #10360      +/-   ##
================================================
+ Coverage         10.42%   10.61%   +0.18%     
================================================
  Files               119      126       +7     
  Lines             20603    20993     +390     
================================================
+ Hits               2148     2228      +80     
- Misses            18455    18765     +310     
Impacted Files Coverage Δ
...ython/custreamz/custreamz/tests/test_dataframes.py 99.39% <0.00%> (-0.01%) ⬇️
python/cudf/cudf/errors.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/ops.py 0.00% <0.00%> (ø)
python/cudf/cudf/datasets.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/scalar.py 0.00% <0.00%> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78b316c...4ba4db9. Read the comment docs.

@vyasr vyasr requested a review from shwina March 1, 2022 00:14
@vyasr
Copy link
Contributor Author

vyasr commented Mar 2, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7120694 into rapidsai:branch-22.04 Mar 2, 2022
@vyasr vyasr deleted the refactor/binops_mixin branch March 9, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants