Fix warnings in test_categorical.py. #10354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
Python
bdice
commented
Feb 24, 2022
| @@ -401,8 +414,9 @@ def test_categorical_as_unordered(pd_str_cat, inplace): | |||
| [ | |||
| pytest.param( | |||
| True, | |||
| marks=pytest.mark.xfail( | |||
| reason="https://github.com/pandas-dev/pandas/issues/43232" | |||
| marks=pytest.mark.skipif( | |||
There was a problem hiding this comment.
This xfail can be replaced by a skipif because the underlying bug pandas-dev/pandas#43232 was resolved in pandas 1.3.4.
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10354 +/- ##
================================================
- Coverage 10.62% 10.62% -0.01%
================================================
Files 122 122
Lines 20973 20974 +1
================================================
Hits 2228 2228
- Misses 18745 18746 +1
Continue to review full report at Codecov.
|
shwina
approved these changes
Feb 25, 2022
|
@gpucibot merge |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR catches or silences warnings in
test_categorical.py. (I am working through one test file at a time so we can enable-Werrin the future.) Most of the warnings come from deprecatedinplacearguments to pandas' categorical functions. Theinplaceargument will be removed in pandas 2.0. Until then, we should just hide the warning.Additionally, I refactored some
inplacebehavior to make the expected behavior of the test clearer.