Support collect aggregations in reduction #10353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sperlingxx <[email protected]>
sperlingxx
added
feature request
jrhemstad
reviewed
Feb 24, 2022
cpp/src/reductions/collect_ops.cu
Outdated
Comment on lines
48
to
50
| auto not_null_pred = [mask = col.null_mask(), offset = col.offset()] __device__(auto i) { | ||
| return bit_is_set(mask, offset + i); | ||
| }; |
There was a problem hiding this comment.
Use make_validity_iterator.
jrhemstad
reviewed
Feb 24, 2022
cpp/src/reductions/collect_ops.cu
Outdated
Comment on lines
52
to
54
| column* null_purged_col = null_purged_table->release().front().release(); | ||
| null_purged_col->set_null_mask(rmm::device_buffer{0, stream, mr}, 0); | ||
| return std::make_unique<list_scalar>(*null_purged_col, true, stream, mr); |
There was a problem hiding this comment.
This makes a copy of null_purged_col and then leaks it.
Suggested change
| column* null_purged_col = null_purged_table->release().front().release(); | |
| null_purged_col->set_null_mask(rmm::device_buffer{0, stream, mr}, 0); | |
| return std::make_unique<list_scalar>(*null_purged_col, true, stream, mr); | |
| auto null_purged_col = null_purged_table->release().front(); | |
| null_purged_col->set_null_mask(rmm::device_buffer{0, stream, mr}, 0); | |
| return std::make_unique<list_scalar>(std::move(*null_purged_col), true, stream, mr); |
There was a problem hiding this comment.
@jrhemstad Change done. Thank you for the catch!
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10353 +/- ##
================================================
- Coverage 10.62% 10.50% -0.12%
================================================
Files 122 127 +5
Lines 20961 21200 +239
================================================
Hits 2228 2228
- Misses 18733 18972 +239
Continue to review full report at Codecov.
|
|
Hi @jrhemstad, could you help to take another look at this PR? Thank you |
jrhemstad
reviewed
Mar 7, 2022
cpp/src/reductions/collect_ops.cu
Outdated
Comment on lines
82
to
89
| std::unique_ptr<scalar> merge_sets(column_view const& col, | ||
| null_equality nulls_equal, | ||
| nan_equality nans_equal, | ||
| rmm::cuda_stream_view stream, | ||
| rmm::mr::device_memory_resource* mr) | ||
| { | ||
| CUDF_EXPECTS(col.type().id() == type_id::LIST, | ||
| "input column of merge_lists must be a list column"); |
There was a problem hiding this comment.
It's more descriptive to just make the parameter a lists_column_view and eliminates the extra error checking.
Suggested change
| std::unique_ptr<scalar> merge_sets(column_view const& col, | |
| null_equality nulls_equal, | |
| nan_equality nans_equal, | |
| rmm::cuda_stream_view stream, | |
| rmm::mr::device_memory_resource* mr) | |
| { | |
| CUDF_EXPECTS(col.type().id() == type_id::LIST, | |
| "input column of merge_lists must be a list column"); | |
| std::unique_ptr<scalar> merge_sets(lists_column_view const& col, | |
| null_equality nulls_equal, | |
| nan_equality nans_equal, | |
| rmm::cuda_stream_view stream, | |
| rmm::mr::device_memory_resource* mr) | |
| { |
jrhemstad
reviewed
Mar 7, 2022
Signed-off-by: sperlingxx <[email protected]>
jrhemstad
approved these changes
Mar 9, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7807
Curreent PR is to support the collect aggregation family in reduction context, which includes collect_list, collect_set, merge_lists, and merge_sets.
The implementations are inspired by corresponding collect aggregations in groupby context.