Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JNI for extract_list_element with index column #10341

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Add JNI for extract_list_element with index column #10341

merged 1 commit into from
Feb 22, 2022

Conversation

firestarman
Copy link
Contributor

This PR is to expose the cudf::list::extract_list_element(column_view, column_view) API to JNI, along with its tests.

closes #10340

Signed-off-by: Firestarman [email protected]

@firestarman firestarman requested a review from a team as a code owner February 22, 2022 07:21
@github-actions github-actions bot added the Java Affects Java cuDF API. label Feb 22, 2022
@firestarman firestarman self-assigned this Feb 22, 2022
@firestarman firestarman added 4 - Needs cuDF (Java) Reviewer feature request New feature or request non-breaking Non-breaking change and removed Java Affects Java cuDF API. labels Feb 22, 2022
@codecov
Copy link

codecov bot commented Feb 22, 2022 •
edited
Loading

Codecov Report

Merging #10341 (b88965e) into branch-22.04 (a7d88cd) will increase coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04   #10341      +/-   ##
================================================
+ Coverage         10.42%   10.63%   +0.20%     
================================================
  Files               119      122       +3     
  Lines             20603    20953     +350     
================================================
+ Hits               2148     2228      +80     
- Misses            18455    18725     +270
Impacted Files Coverage Δ
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/main.py 0.00% <ø> (ø)
python/cudf/cudf/_lib/strings/__init__.py 0.00% <ø> (ø)
python/cudf/cudf/_version.py 0.00% <ø> (ø)
python/cudf/cudf/comm/gpuarrow.py 0.00% <ø> (ø)
python/cudf/cudf/core/_base_index.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/column.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/datetime.py 0.00% <ø> (ø)
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a17f28...b88965e. Read the comment docs.

@sperlingxx
Copy link
Contributor

LGTM

@revans2
Copy link
Contributor

revans2 commented Feb 22, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit add6990 into rapidsai:branch-22.04 Feb 22, 2022
@firestarman firestarman deleted the list_extract branch February 23, 2022 00:54
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

Assignees

@firestarman firestarman

Labels
4 - Needs Review Waiting for reviewer to review or respond feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Add JNI support for list::extract_list_element(column_view, column_view)
4 participants
@firestarman @sperlingxx @revans2 @vyasr