Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JNI: Support appending DECIMAL128 into ColumnBuilder in terms of byte array #10338

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

sperlingxx
Copy link
Contributor

This PR is to add new append method for HostColumnVector.ColumnBuilder. This newly-added method appendDecimal128 allows users to add binary data, which represents the unscaled value of BigDecimal, as cuDF Decimal128.
This PR serves as a prerequisite of NVIDIA/spark-rapids#4784.

@sperlingxx sperlingxx requested a review from a team as a code owner February 21, 2022 11:16
@github-actions github-actions bot added the Java Affects Java cuDF API. label Feb 21, 2022
@sperlingxx sperlingxx added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS and removed Java Affects Java cuDF API. labels Feb 21, 2022
@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #10338 (a9af8b6) into branch-22.04 (8b0737d) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04   #10338      +/-   ##
================================================
- Coverage         10.67%   10.63%   -0.05%     
================================================
  Files               122      122              
  Lines             20874    20953      +79     
================================================
  Hits               2228     2228              
- Misses            18646    18725      +79     
Impacted Files Coverage Δ
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
python/cudf/cudf/testing/_utils.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/_base_index.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/string.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/indexed_frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/groupby/groupby.py 0.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b0737d...a9af8b6. Read the comment docs.

@sperlingxx
Copy link
Contributor Author

@gpucibot rerun tests

@revans2
Copy link
Contributor

revans2 commented Feb 22, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit cf65ac3 into rapidsai:branch-22.04 Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants