Fix warnings in test_binops.py. #10327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
improvement
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10327 +/- ##
================================================
+ Coverage 10.42% 10.61% +0.19%
================================================
Files 119 122 +3
Lines 20603 20981 +378
================================================
+ Hits 2148 2228 +80
- Misses 18455 18753 +298
Continue to review full report at Codecov.
|
vyasr
approved these changes
Feb 19, 2022
Co-authored-by: Vyas Ramasubramani <[email protected]>
|
@gpucibot merge |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR catches or silences warnings in
test_binops.py. (I am working through one test file at a time so we can enable-Werrin the future.) Most of the warnings come from deprecated binops inside cudf. Once the deprecated code is removed, these tests will fail until the workaround is removed.Another warning comes from numpy,
DeprecationWarning: elementwise comparison failed; this will raise an error in the future.. This warning can be circumvented by comparing withseries == scalarinstead ofscalar == series. I believe that seeing this warning is expected when comparingscalar == series, if both numpy and pandas/cudf implement__eq__that accept one another's array-like types, but I'm not certain.