Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move hash type declarations to hashing.hpp #10320

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Move hash type declarations to hashing.hpp #10320

merged 1 commit into from
Feb 18, 2022

Conversation

davidwendt
Copy link
Contributor

Move the hash_id and DEFAULT_HASH_SEED declarations from types.hpp to hashing.hpp.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 17, 2022
@davidwendt davidwendt self-assigned this Feb 17, 2022
@github-actions github-actions bot added the Python Affects Python cuDF API. label Feb 17, 2022
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #10320 (f12194d) into branch-22.04 (a7d88cd) will increase coverage by 0.21%.
The diff coverage is n/a.

❗ Current head f12194d differs from pull request most recent head fb6cd2c. Consider uploading reports for the commit fb6cd2c to get more accurate results

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04   #10320      +/-   ##
================================================
+ Coverage         10.42%   10.63%   +0.21%     
================================================
  Files               119      122       +3     
  Lines             20603    20940     +337     
================================================
+ Hits               2148     2228      +80     
- Misses            18455    18712     +257
Impacted Files Coverage Δ
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/main.py 0.00% <ø> (ø)
python/cudf/cudf/_version.py 0.00% <ø> (ø)
python/cudf/cudf/comm/gpuarrow.py 0.00% <ø> (ø)
python/cudf/cudf/core/_base_index.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/column.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/datetime.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/methods.py 0.00% <ø> (ø)
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e986fd...fb6cd2c. Read the comment docs.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Feb 17, 2022
@davidwendt davidwendt marked this pull request as ready for review February 17, 2022 20:09
@davidwendt davidwendt requested review from a team as code owners February 17, 2022 20:09
galipremsagar
galipremsagar approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cython approval

brandon-b-miller
brandon-b-miller approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@brandon-b-miller brandon-b-miller left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple cython changes lgtm.

edit: prem beat me to it :)

@bdice
Copy link
Contributor

bdice commented Feb 17, 2022

Nice fix. I was considering this recently, so I'm glad you made the change.

@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ec614ac into rapidsai:branch-22.04 Feb 18, 2022
@davidwendt davidwendt deleted the move-hash-type-defs branch February 18, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@bdice bdice bdice approved these changes

@rgsl888prabhu rgsl888prabhu Awaiting requested review from rgsl888prabhu rgsl888prabhu is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwendt @bdice @galipremsagar @brandon-b-miller