-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++17 cleanup: traits replace ::value
with _v
#10319
C++17 cleanup: traits replace ::value
with _v
#10319
Conversation
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 🔥
::value
with _v
@karthikeyann I believe the failure here is caused by the issue described in #10323. tl;dr merge in the latest branch-22.04 and I think style checks will pass. |
Here are some ideas off the top of my head. I'll come back and add to this list later if I think of anything, but other reviewers should feel free to edit this comment and add too. These are definitely out of scope for this PRs and could be added separately; in fact, this comment should probably be converted into a separate issue after we've compiled ideas.
More complicated changes or changes that require more case-by-case analysis:
|
@karthikeyann You seem to miss |
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10319 +/- ##
================================================
+ Coverage 10.42% 10.63% +0.20%
================================================
Files 119 122 +3
Lines 20603 20953 +350
================================================
+ Hits 2148 2228 +80
- Misses 18455 18725 +270
Continue to review full report at Codecov.
|
@gpucibot merge |
std::is_*<T>::value
withstd::is_*_v<T>
Please suggest any other C++17 tech debts.