Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraneous build.sh parameter #10313

Merged
merged 2 commits into from
Feb 17, 2022

Conversation

ajschmidt8
Copy link
Member

The -l flag was introduced in #3504, but I don't see it being used anywhere. Seems safe to remove unless anyone else thinks otherwise.

The `-l` flag was introduced in rapidsai#3504, but I don't see it being used anywhere. Seems safe to remove unless anyone else thinks otherwise.
@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 16, 2022
@ajschmidt8 ajschmidt8 requested a review from a team as a code owner February 16, 2022 23:53
@github-actions github-actions bot added the gpuCI label Feb 16, 2022
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #10313 (8c832de) into branch-22.04 (a7d88cd) will increase coverage by 0.23%.
The diff coverage is n/a.

❗ Current head 8c832de differs from pull request most recent head aaa9655. Consider uploading reports for the commit aaa9655 to get more accurate results

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04   #10313      +/-   ##
================================================
+ Coverage         10.42%   10.66%   +0.23%     
================================================
  Files               119      122       +3     
  Lines             20603    20896     +293     
================================================
+ Hits               2148     2228      +80     
- Misses            18455    18668     +213     
Impacted Files Coverage Δ
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/main.py 0.00% <ø> (ø)
python/cudf/cudf/_version.py 0.00% <ø> (ø)
python/cudf/cudf/comm/gpuarrow.py 0.00% <ø> (ø)
python/cudf/cudf/core/_base_index.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/column.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/datetime.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/methods.py 0.00% <ø> (ø)
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 895b007...aaa9655. Read the comment docs.

Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ajschmidt8
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4e986fd into rapidsai:branch-22.04 Feb 17, 2022
@ajschmidt8 ajschmidt8 deleted the rm-build-param branch February 17, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants