-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add const qualifier to MurmurHash3_32::hash_combine #10311
Add const qualifier to MurmurHash3_32::hash_combine #10311
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10311 +/- ##
================================================
+ Coverage 10.42% 10.66% +0.23%
================================================
Files 119 122 +3
Lines 20603 20896 +293
================================================
+ Hits 2148 2228 +80
- Misses 18455 18668 +213
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@gpucibot merge |
Fixes declaration of the internal
MurmurHash3_32::hash_combine()
to add theconst
qualifier.Found this while working on #10270 and trying to call
hash_combine
from aconst
instance.