Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add const qualifier to MurmurHash3_32::hash_combine #10311

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

davidwendt
Copy link
Contributor

Fixes declaration of the internal MurmurHash3_32::hash_combine() to add the const qualifier.

Found this while working on #10270 and trying to call hash_combine from a const instance.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 16, 2022
@davidwendt davidwendt self-assigned this Feb 16, 2022
@davidwendt davidwendt requested a review from a team as a code owner February 16, 2022 22:37
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #10311 (78e2abc) into branch-22.04 (a7d88cd) will increase coverage by 0.23%.
The diff coverage is n/a.

❗ Current head 78e2abc differs from pull request most recent head 35a6099. Consider uploading reports for the commit 35a6099 to get more accurate results

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04   #10311      +/-   ##
================================================
+ Coverage         10.42%   10.66%   +0.23%     
================================================
  Files               119      122       +3     
  Lines             20603    20896     +293     
================================================
+ Hits               2148     2228      +80     
- Misses            18455    18668     +213     
Impacted Files Coverage Δ
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/main.py 0.00% <ø> (ø)
python/cudf/cudf/_version.py 0.00% <ø> (ø)
python/cudf/cudf/comm/gpuarrow.py 0.00% <ø> (ø)
python/cudf/cudf/core/_base_index.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/column.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/datetime.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/methods.py 0.00% <ø> (ø)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 183eec3...35a6099. Read the comment docs.

Copy link
Contributor

@codereport codereport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit fdad597 into rapidsai:branch-22.04 Feb 17, 2022
@davidwendt davidwendt deleted the const-hash-combine branch February 17, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants