Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copyright check as pre-commit hook. #10290

Merged
merged 2 commits into from
Feb 15, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Feb 14, 2022

Since #10253 added copyright checks, it is helpful to have the corresponding check enabled via pre-commit so that copyright issues can be found locally before pushing.

@vyasr vyasr added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 14, 2022
@vyasr vyasr self-assigned this Feb 14, 2022
@github-actions github-actions bot added the gpuCI label Feb 14, 2022
@vyasr vyasr force-pushed the feature/copyright_pre_commit branch from 2a3c0cd to 0ca2706 Compare February 14, 2022 23:39
@vyasr vyasr requested a review from a team as a code owner February 14, 2022 23:39
@github-actions github-actions bot removed the gpuCI label Feb 14, 2022
@vyasr vyasr removed the request for review from a team February 14, 2022 23:40
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #10290 (0ca2706) into branch-22.04 (a7d88cd) will increase coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04   #10290      +/-   ##
================================================
+ Coverage         10.42%   10.67%   +0.25%     
================================================
  Files               119      122       +3     
  Lines             20603    20869     +266     
================================================
+ Hits               2148     2228      +80     
- Misses            18455    18641     +186     
Impacted Files Coverage Δ
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/main.py 0.00% <ø> (ø)
python/cudf/cudf/_version.py 0.00% <ø> (ø)
python/cudf/cudf/comm/gpuarrow.py 0.00% <ø> (ø)
python/cudf/cudf/core/_base_index.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/categorical.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/column.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/datetime.py 0.00% <ø> (ø)
python/cudf/cudf/core/column/methods.py 0.00% <ø> (ø)
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a443dd1...0ca2706. Read the comment docs.

@vyasr
Copy link
Contributor Author

vyasr commented Feb 15, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 17b7907 into rapidsai:branch-22.04 Feb 15, 2022
@vyasr vyasr deleted the feature/copyright_pre_commit branch March 9, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants