Add tests of reflected ufuncs and fix behavior of logical reflected ufuncs #10261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
bug
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10261 +/- ##
=============================================
Coverage 10.42% 10.42%
=============================================
Files 119 122 +3
Lines 20603 20588 -15
=============================================
- Hits 2148 2147 -1
+ Misses 18455 18441 -14
Continue to review full report at Codecov.
|
isVoid
reviewed
Feb 10, 2022
bdice
approved these changes
Feb 11, 2022
vyasr
force-pushed
the
feature/more_operators
branch
from
bc2adad to
f516dfa
Compare
isVoid
approved these changes
Feb 11, 2022
galipremsagar
approved these changes
Feb 11, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes cases like
cupy.array([1, 2, 3]) < cudf.Series([1, 2, 3]). The code would previously attempt to find a reflected operatorSeries.__rle__, but no such operator exists because of the inherent symmetry in comparison operators. These changes fix the detection of such operators to just use operator__ge__in this case.